Fix Parent Check Condition in buildTermsTree
#66006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @yellowmastodon. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
torounit
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.81 MB ℹ️ View Unchanged
|
torounit
commented
Oct 10, 2024
| @@ -14,14 +14,16 @@ export function buildTermsTree( flatTerms ) { | |||
| const flatTermsWithParentAndChildren = flatTerms.map( ( term ) => { | |||
| return { | |||
| children: [], | |||
| parent: null, | |||
| parent: undefined, | |||
There was a problem hiding this comment.
Terms fetched by getEntityRecords use parent: undefined, so we match them.
Mamaduka
reviewed
Oct 23, 2024
| @@ -4,14 +4,14 @@ | |||
| import { buildTermsTree } from '../terms'; | |||
|
|
|||
| describe( 'buildTermsTree()', () => { | |||
| it( 'Should return same array as input with null parent and empty children added if parent is never specified.', () => { | |||
| it( 'Should return same array as input with undefined parent and empty children added if parent is never specified.', () => { | |||
There was a problem hiding this comment.
Should we test both cases of null and undefined?
Mamaduka
reviewed
Oct 23, 2024
packages/editor/src/utils/terms.js
Outdated
| ...term, | ||
| }; | ||
| } ); | ||
|
|
||
| // All terms should have a `parent` because we're about to index them by it. | ||
| if ( | ||
| flatTermsWithParentAndChildren.some( ( { parent } ) => parent === null ) | ||
| flatTermsWithParentAndChildren.some( | ||
| ( { parent } ) => parent === undefined || parent === null |
There was a problem hiding this comment.
In which case will the parent: null be?
There was a problem hiding this comment.
@Mamaduka I checked both HierarchicalTermSelector and PageAttributesParent and parent is undefined if parent does not exist. can we remove parent === null ?
There was a problem hiding this comment.
can we remove parent === null?
If it's never null then I guess we can remove it.
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Use undefined instead of null in `buildTermsTree` * allow null * use undefined * remove null checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The buildTermsTree function skips the process of converting terms into a tree structure if all terms in the passed array have no parent. Previously, this condition was determined by checking if
parent === null, but it failed to evaluate correctly when parent was undefined. We will modify it to handle both null and undefined correctly.Why?
fix: #65704.
How?
Check
parent === undefiendTesting Instructions
Try #65704.
Testing Instructions for Keyboard
Screenshots or screencast